Add code changes for the implementation of the low-resolution B #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumevernieres
added
the
hera-GW-RT
emcbot
added
hera-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
shlyaeva
previously approved these changes
Jan 14, 2025
guillaumevernieres
added
hera-GW-RT
emcbot
added
hera-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Failed
guillaumevernieres
added
hercules-GW-RT
guillaumevernieres
added
hera-GW-RT
emcbot
added
hera-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hercules-GW-RT-Failed
RussTreadon-NOAA
added
hercules-GW-RT
|
Weird, it looks like it used the wrong commit of the g-w branch. I merged develop before resubmitting the ci but that;s not what was cloned here: /work2/noaa/da/role-da/CI/hercules/GDASApp/workflow/PR/1441/global-workflow |
emcbot
added
hercules-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
orion-GW-RT-Passed
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hercules-GW-RT-Passed
RussTreadon-NOAA
approved these changes
Feb 4, 2025
|
Here are the changes that I needed to do for the recenter task to succeed with a zero exit status: diff --git a/parm/soca/berror/soca_ensrecenter.yaml b/parm/soca/berror/soca_ensrecenter.yaml
index b700601..b7d8e20 100644
--- a/parm/soca/berror/soca_ensrecenter.yaml
+++ b/parm/soca/berror/soca_ensrecenter.yaml
@@ -60,5 +60,5 @@ output increment:
date: '{{ MARINE_WINDOW_END_ISO }}'
exp: trash
type: incr
- output file: 'ocn.recenter.incr.%mem%.nc'
+ output file: 'recenter.incr.%mem%.nc'
pattern: '%mem%'and diff --git a/utils/soca/gdas_ens_handler.h b/utils/soca/gdas_ens_handler.h
index 741055c..dd5fe9c 100644
--- a/utils/soca/gdas_ens_handler.h
+++ b/utils/soca/gdas_ens_handler.h
@@ -169,7 +171,30 @@ namespace gdasapp {
postProcIncr.setToZero(incr);
// Save the increments used to initialize the ensemble forecast
- result = postProcIncr.save(mom6_incr, i+1);
+ result = postProcIncr.save(mom6_incr, i+1, {"ocn"});It fixes two issues: missing ice file (that we don't use in this usecase anyway) and wrong ocean file name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
Dependencies
Work done in this PR
Interp to low-resolution:
Testing
Visual check showing the variance explained by the steric height (30 members)
left is native resolution, right is on the 1/2 deg grid.
"Science" note: The explained variance above is almost the opposite to what I would have expected, and what we saw in the previous offline ensemble, or even what we see in tendencies. Check if there's a bug in the explained variance calculation.
Automated CI tests to run in Global Workflow